Skip to content

core/txpool/legacypool: remove redundant check for floatingRatio #27477#1913

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:remove-floatingRatio
Jan 13, 2026
Merged

core/txpool/legacypool: remove redundant check for floatingRatio #27477#1913
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:remove-floatingRatio

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Jan 5, 2026

Proposed changes

Ref: ethereum#27477

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 5, 2026 09:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gzliudan gzliudan requested review from AnilChinchawale, anunay-xin, benjamin202410, liam-lai and wanwiset25 and removed request for Copilot January 5, 2026 09:02
@gzliudan gzliudan force-pushed the remove-floatingRatio branch from 28fa3ad to 912e622 Compare January 5, 2026 10:39
Copilot AI review requested due to automatic review settings January 5, 2026 10:39
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant condition check in the transaction pool's discard logic. The check floatingRatio == 0 is dead code since floatingRatio is a constant defined as 1 and can never be zero.

Key Changes:

  • Removed the redundant || floatingRatio == 0 condition from the heap selection logic in the Discard method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AnilChinchawale AnilChinchawale merged commit a7ddd8a into XinFinOrg:dev-upgrade Jan 13, 2026
19 checks passed
@gzliudan gzliudan deleted the remove-floatingRatio branch January 13, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnilChinchawale AnilChinchawale AnilChinchawale approved these changes

@wanwiset25 wanwiset25 wanwiset25 approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@anunay-xin anunay-xin anunay-xin approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gzliudan @AnilChinchawale @wanwiset25 @benjamin202410 @anunay-xin